Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add noUnusedParameters config #2960

Merged
merged 3 commits into from Feb 24, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 23, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Add noUnusedParameters to tsconfig.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Please merge #2959 before merging this.

@vthinkxie vthinkxie mentioned this pull request Feb 23, 2019
7 tasks
@netlify
Copy link

netlify bot commented Feb 23, 2019

Deploy preview for ng-zorro-master ready!

Built with commit a669af6

https://deploy-preview-2960--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 23, 2019

Codecov Report

Merging #2960 into master will increase coverage by <.01%.
The diff coverage is 78.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2960      +/-   ##
==========================================
+ Coverage   97.35%   97.36%   +<.01%     
==========================================
  Files         529      529              
  Lines       11081    11081              
  Branches      803      803              
==========================================
+ Hits        10788    10789       +1     
+ Misses        183      182       -1     
  Partials      110      110
Impacted Files Coverage Δ
components/core/util/logger/logger.service.ts 70.58% <0%> (+3.92%) ⬆️
components/grid/nz-col.directive.ts 100% <100%> (ø) ⬆️
components/select/nz-option-container.component.ts 100% <100%> (ø) ⬆️
...s/date-picker/lib/decade/decade-panel.component.ts 100% <100%> (ø) ⬆️
...nts/date-picker/lib/month/month-table.component.ts 100% <100%> (ø) ⬆️
components/tree-select/nz-tree-select.component.ts 99.06% <100%> (ø) ⬆️
components/pagination/nz-pagination.component.ts 100% <100%> (ø) ⬆️
...nents/date-picker/lib/year/year-panel.component.ts 100% <100%> (ø) ⬆️
components/cascader/nz-cascader.component.ts 99.22% <100%> (ø) ⬆️
components/slider/nz-slider.component.ts 94.06% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44aaa32...a669af6. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

log(...args: any[]): void {
if (this._loggerState) {
// console.log(...args);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wilsoncook plz check this.

@vthinkxie vthinkxie merged commit 87cf260 into NG-ZORRO:master Feb 24, 2019
@wzhudev wzhudev deleted the tsconfig-parameters branch February 24, 2019 12:59
@vthinkxie vthinkxie mentioned this pull request Mar 4, 2019
12 tasks
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* build: add noUnusedLocals config

* build: add noUnusedParameters config
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* build: add noUnusedLocals config

* build: add noUnusedParameters config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants