Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(module:badge): format the code in template #314

Merged
merged 2 commits into from
Sep 22, 2017

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.774% when pulling d78799d on HsuanXyz:style-badge into 6e4794b on NG-ZORRO:master.

@vthinkxie
Copy link
Member

Hi @hsuanxyz , thanks for your pr. Tt is right to format the template code, but you may not notice that it will bring unnecessary spaces to the element which will affects the style.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 40.791% when pulling 363ac08 on HsuanXyz:style-badge into 6e4794b on NG-ZORRO:master.

@vthinkxie
Copy link
Member

Hi @hsuanxyz , it would be better to keep the commit history clean.
https://github.com/NG-ZORRO/ng-zorro-antd/pull/314/commits

@vthinkxie vthinkxie merged commit 4498ef9 into NG-ZORRO:master Sep 22, 2017
@hsuanxyz hsuanxyz deleted the style-badge branch September 30, 2017 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants