Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] fix(module:collapse): fix closed collapse cannot be reopned in some … #3216

Closed
wants to merge 3 commits into from

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Apr 3, 2019

…browsers

close #3098

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3098

In browsers like Safari, IE or Edge, closed panels cannot be reopened because display: none style is not removed.

What is the new behavior?

Use CSS visibility property instead of display. Now on Safari, collapsed panels can be un-collapsed.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev changed the title fix(module:collapse): fix closed collapse cannot be reopnned in some … fix(module:collapse): fix closed collapse cannot be reopned in some … Apr 3, 2019
@netlify
Copy link

netlify bot commented Apr 3, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 3d01b9d

https://deploy-preview-3216--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #3216 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3216   +/-   ##
=======================================
  Coverage   97.37%   97.37%           
=======================================
  Files         559      559           
  Lines       11627    11627           
  Branches      835      835           
=======================================
  Hits        11322    11322           
  Misses        193      193           
  Partials      112      112
Impacted Files Coverage Δ
components/core/animation/collapse.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c0d53...3d01b9d. Read the comment docs.

@wzhudev wzhudev requested a review from vthinkxie April 3, 2019 12:26
@wzhudev wzhudev changed the title fix(module:collapse): fix closed collapse cannot be reopned in some … [draft] fix(module:collapse): fix closed collapse cannot be reopned in some … Apr 5, 2019
@wzhudev
Copy link
Member Author

wzhudev commented Apr 7, 2019

I am going to dig deeper on this potential bug of Angular.

@RayXia95
Copy link

RayXia95 commented Apr 9, 2019

I have the same exact problem with unable to expand nz-collapse across other desktop browsers and mobile browsers. This fix should be tested on mobile browsers also.

@wzhudev wzhudev closed this Apr 12, 2019
@wzhudev wzhudev deleted the collapse-fold branch April 12, 2019 04:01
@RayXia95
Copy link

Why was this PR closed?

@kjavia
Copy link

kjavia commented Apr 14, 2019

Anyone facing this issue can switch off animations (as a workaround, until this is officially fixed)

https://deploy-preview-3216--ng-zorro-master.netlify.com/docs/animations/en

@wzhudev
Copy link
Member Author

wzhudev commented Apr 15, 2019

@RayXia95 Because it's a bug of Angular's and this fix is not neat. But you can use this as a hack.

@KerryXuanWang
Copy link

Anyone facing this issue can switch off animations (as a workaround, until this is officially fixed)

https://deploy-preview-3216--ng-zorro-master.netlify.com/docs/animations/en

can't open it now, can you please give an available link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-collapse doesn't open panel at Safari
4 participants