-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] fix(module:collapse): fix closed collapse cannot be reopned in some … #3216
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 3d01b9d |
Codecov Report
@@ Coverage Diff @@
## master #3216 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 559 559
Lines 11627 11627
Branches 835 835
=======================================
Hits 11322 11322
Misses 193 193
Partials 112 112
Continue to review full report at Codecov.
|
I am going to dig deeper on this potential bug of Angular. |
I have the same exact problem with unable to expand nz-collapse across other desktop browsers and mobile browsers. This fix should be tested on mobile browsers also. |
Why was this PR closed? |
Anyone facing this issue can switch off animations (as a workaround, until this is officially fixed) https://deploy-preview-3216--ng-zorro-master.netlify.com/docs/animations/en |
@RayXia95 Because it's a bug of Angular's and this fix is not neat. But you can use this as a hack. |
can't open it now, can you please give an available link? |
…browsers
close #3098
PR Checklist
Please check if your PR fulfills the following requirements:
[ ] Tests for the changes have been added (for bug fixes / features)Need Safari or IE or Edge to test it.[ ] Docs have been added / updated (for bug fixes / features)Not needed.PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3098
In browsers like Safari, IE or Edge, closed panels cannot be reopened because
display: none
style is not removed.What is the new behavior?
Use CSS
visibility
property instead ofdisplay
. Now on Safari, collapsed panels can be un-collapsed.Does this PR introduce a breaking change?
Other information