Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(menu): animate expand/collapse menu #330

Merged
merged 1 commit into from
Sep 30, 2017
Merged

feature(menu): animate expand/collapse menu #330

merged 1 commit into from
Sep 30, 2017

Conversation

maroon1
Copy link
Contributor

@maroon1 maroon1 commented Sep 19, 2017

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

子菜单展开/收起时,高度突变
Issue Number: N/A

What is the new behavior?

子菜单展开/收起时,高度变化有动画效果

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.774% when pulling a2e07d0 on Maroon1:menu-expand-collapse-animation into 6e4794b on NG-ZORRO:master.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your pr very much, height should not be animated when [nzMode]="'vertical'", the bugs will happened with nested submenu.

@maroon1
Copy link
Contributor Author

maroon1 commented Sep 24, 2017

@vthinkxie 请问你说的 bug 具体是指什么?在我的测试中是发现第2级菜单无法正常显示,目前已经确定是 overflow: hidden 设置的问题,可以通过在 transition 方法中设置临时的 overflow: hidden 样式来解决。

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 40.747% when pulling 24aa8e8 on Maroon1:menu-expand-collapse-animation into 6e4794b on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 40.752% when pulling 2e0cf2c on Maroon1:menu-expand-collapse-animation into 6e4794b on NG-ZORRO:master.

@vthinkxie
Copy link
Member

It would be better not animation height when [nzMode]="'vertical'"

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 40.802% when pulling 4e0d67f on Maroon1:menu-expand-collapse-animation into 6e4794b on NG-ZORRO:master.

@vthinkxie
Copy link
Member

Hi, @maroon1 ,please keep your commit history clean, you can use rebase and sqush to remove unused commit history.
https://github.com/NG-ZORRO/ng-zorro-antd/pull/330/commits

@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 40.793% when pulling 84e5da8 on Maroon1:menu-expand-collapse-animation into 8fb32c6 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 7edba94 into NG-ZORRO:master Sep 30, 2017
@maroon1 maroon1 deleted the menu-expand-collapse-animation branch October 10, 2017 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants