Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:form): fix form overlap #3633

Merged
merged 1 commit into from
Jun 24, 2019
Merged

fix(module:form): fix form overlap #3633

merged 1 commit into from
Jun 24, 2019

Conversation

vthinkxie
Copy link
Member

close #3607

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Jun 24, 2019

Deploy preview for ng-zorro-master ready!

Built with commit fd30aff

https://deploy-preview-3633--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #3633 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3633      +/-   ##
==========================================
+ Coverage   95.46%   95.46%   +<.01%     
==========================================
  Files         685      685              
  Lines       14080    14081       +1     
  Branches     1874     1875       +1     
==========================================
+ Hits        13442    13443       +1     
  Misses        226      226              
  Partials      412      412
Impacted Files Coverage Δ
components/form/nz-form-control.component.ts 93.61% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db4f9b...fd30aff. Read the comment docs.

@vthinkxie vthinkxie merged commit 0fc7d05 into NG-ZORRO:master Jun 24, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzValidateStatus & nzHasFeedback overlap with nzSuffix
1 participant