Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:descriptions): fix warning without logger #3663

Merged
merged 1 commit into from
Jun 27, 2019
Merged

fix(module:descriptions): fix warning without logger #3663

merged 1 commit into from
Jun 27, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jun 27, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: fix a demo

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@wzhudev wzhudev requested a review from vthinkxie June 27, 2019 08:54
@netlify
Copy link

netlify bot commented Jun 27, 2019 •
edited
Loading

Deploy preview for ng-zorro-master ready!

Built with commit fdb97b7

https://deploy-preview-3663--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 27, 2019 •
edited
Loading

Codecov Report

Merging #3663 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3663   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files         698      698           
  Lines       14486    14486           
  Branches     1913     1913           
=======================================
  Hits        13823    13823           
  Misses        237      237           
  Partials      426      426
Impacted Files Coverage Δ
...mponents/descriptions/nz-descriptions.component.ts 95.83% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb14096...fdb97b7. Read the comment docs.

fix(module:descriptions): fix warning without logger
fdb97b7 
fix: fix test

fix: test

fix: autoDetectChanges
vthinkxie
vthinkxie approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 5826fc1 into NG-ZORRO:master Jun 27, 2019
@wzhudev wzhudev deleted the fix-descriptions branch June 28, 2019 12:11
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@Ricbet
fix(module:descriptions): fix warning without logger (NG-ZORRO#3663)
52a58b7
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@vthinkxie
fix(module:descriptions): fix warning without logger (NG-ZORRO#3663)
51efe8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vthinkxie vthinkxie vthinkxie approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wzhudev @vthinkxie