Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:input-number): add nzBlur & nzFocus property #406

Merged
merged 1 commit into from
Oct 14, 2017

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #396

What is the new behavior?

inf

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

如果像 nz-input 一样处理的话,当点击上下按钮时会出发多余的事件,因此我做了一些必要处理。

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 41.306% when pulling 3ae30ac on HsuanXyz:feat-number-input into 802a98c on NG-ZORRO:master.

Copy link
Contributor

@tigercosmos tigercosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just change the necessary part

[attr.max]="nzMax"
[attr.step]="_step"
autocomplete="off">
#inputNumber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the code you add, why did you shift the code?
It seems no need to do this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want output property to be adjacent.

@wilsoncook wilsoncook merged commit a49a382 into NG-ZORRO:master Oct 14, 2017
@LinboLen
Copy link
Contributor

I remember angular team have provided model change on blur

angular/angular#18594

@hsuanxyz hsuanxyz deleted the feat-number-input branch October 17, 2017 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants