Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(showcase): add note to textarea #435

Merged
merged 1 commit into from
Oct 21, 2017
Merged

Conversation

tigercosmos
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

Add note on textarea showcase in nzInput. Let the description be more complete.

r? @vthinkxie

@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.278% when pulling 526e2a8 on tigercosmos:input into 03b87c1 on NG-ZORRO:master.

@wilsoncook
Copy link
Member

@tigercosmos More better to add the usage of nzRows parameter under the API section, could you?

@tigercosmos
Copy link
Contributor Author

I think we can add at both "showcase" and "API ". We usually read showcase first, and go to read API if something are not clear.
How do you think?

@wilsoncook
Copy link
Member

Yeah, provide more info. of usage about nzRows below in API is better

@tigercosmos
Copy link
Contributor Author

sure

@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.268% when pulling 6bde480 on tigercosmos:input into a49a382 on NG-ZORRO:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.268% when pulling 6bde480 on tigercosmos:input into a49a382 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 4c7353a into NG-ZORRO:master Oct 21, 2017
@tigercosmos tigercosmos deleted the input branch October 21, 2017 08:58
@tigercosmos
Copy link
Contributor Author

thanks

wilsoncook pushed a commit that referenced this pull request Oct 28, 2017
wilsoncook added a commit that referenced this pull request Oct 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants