Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type guard for isNotNil #4431

Merged
merged 1 commit into from
Nov 18, 2019
Merged

add type guard for isNotNil #4431

merged 1 commit into from
Nov 18, 2019

Conversation

xiaoxiangmoe
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Nov 13, 2019

Deploy preview for ng-zorro-master ready!

Built with commit e9c2a2a

https://deploy-preview-4431--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Nov 13, 2019

Codecov Report

Merging #4431 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4431      +/-   ##
==========================================
+ Coverage   92.23%   92.24%   +<.01%     
==========================================
  Files         522      522              
  Lines       11104    11104              
  Branches     2016     2016              
==========================================
+ Hits        10242    10243       +1     
  Misses        435      435              
+ Partials      427      426       -1
Impacted Files Coverage Δ
components/core/util/check.ts 85.29% <ø> (ø) ⬆️
components/time-picker/time-holder.ts 96.49% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367dc6c...e9c2a2a. Read the comment docs.

@simplejason
Copy link
Member

Sorry for this PR, we need to roll back this PR because it does not meet our commit specification.

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants