-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:nz-select): fix nz-select blur event will not be emitted #4458
fix(module:nz-select): fix nz-select blur event will not be emitted #4458
Conversation
1fc6f38
to
69b29d3
Compare
Deploy preview for ng-zorro-master ready! Built with commit 1fc6f38 |
Codecov Report
@@ Coverage Diff @@
## master #4458 +/- ##
==========================================
+ Coverage 92.23% 92.23% +<.01%
==========================================
Files 522 522
Lines 11107 11109 +2
Branches 2018 2018
==========================================
+ Hits 10244 10246 +2
Misses 436 436
Partials 427 427
Continue to review full report at Codecov.
|
这个 pr 与 #3708 需求冲突,估计要重新讨论这部分的实现,建议先不要依赖 nzBlur,改用 fromEvent 操作 |
@vthinkxie 其实不看需求,但看我添加的测试的话,以前的代码是不能过的,也就是说原来只是靠让一些代码失效来解决一些问题,感觉也不太合理呀。^_^ |
核心问题在于对nzBlur的理解,之前很多issue的提出者都觉得nzBlur应该针对的是当前组件的外壳,而不是里面的input,你认为nzBlur应该针对的是里面的input,而不是外壳,这就是冲突的地方,上一次改动是按照了之前issue提出者的希望进行了修改。 |
@vthinkxie 谢谢,已经用 fromEvent解决了。其实你可以看我 issue的链接,https://ng-zorro-antd-start-jkfcwi.stackblitz.io 这个例子很明显能看出现在的行为不合理。当我点击这个选择框,它明明是打开了,而且焦点也一直focus,却触发了 blur函数,这应该不是壳子还是input的理解的问题了 |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #4452
What is the new behavior?
Does this PR introduce a breaking change?
Other information