Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:form): reactive form support warning status #4891

Merged
merged 2 commits into from Mar 20, 2020
Merged

feat(module:form): reactive form support warning status #4891

merged 2 commits into from Mar 20, 2020

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4525

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 16, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #4891 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4891      +/-   ##
==========================================
- Coverage   91.51%   91.49%   -0.03%     
==========================================
  Files         543      543              
  Lines       13781    13781              
  Branches     2046     2046              
==========================================
- Hits        12612    12609       -3     
- Misses        698      703       +5     
+ Partials      471      469       -2
Impacted Files Coverage Δ
components/form/form-control.component.ts 94.11% <100%> (ø) ⬆️
components/table/src/table/tbody.component.ts 85.71% <0%> (-14.29%) ⬇️
components/table/src/table/tr-measure.component.ts 86.95% <0%> (-13.05%) ⬇️
components/time-picker/time-holder.ts 97.98% <0%> (+1.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2f85d...f92172d. Read the comment docs.

@vthinkxie vthinkxie merged commit b1873da into NG-ZORRO:master Mar 20, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:form): reactive form support warning status

* docs: update style
@danranVm danranVm deleted the form-warning-tips branch April 9, 2020 14:28
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:form): reactive form support warning status

* docs: update style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants