Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module:date-picker): use directive instead of extends class #4898

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

wenqi73
Copy link
Member

@wenqi73 wenqi73 commented Mar 17, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 17, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #4898 into master will decrease coverage by <.01%.
The diff coverage is 96.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4898      +/-   ##
==========================================
- Coverage   91.51%   91.51%   -0.01%     
==========================================
  Files         543      542       -1     
  Lines       13786    13771      -15     
  Branches     2045     2045              
==========================================
- Hits        12616    12602      -14     
  Misses        698      698              
+ Partials      472      471       -1
Impacted Files Coverage Δ
components/date-picker/lib/util.ts 100% <ø> (+2.5%) ⬆️
components/date-picker/testing/util.ts 100% <ø> (ø) ⬆️
...omponents/date-picker/calendar-footer.component.ts 96% <ø> (ø) ⬆️
components/date-picker/picker.component.ts 94.11% <ø> (ø) ⬆️
components/date-picker/inner-popup.component.ts 88.46% <ø> (ø) ⬆️
...mponents/date-picker/date-range-popup.component.ts 91.87% <ø> (ø) ⬆️
components/date-picker/year-picker.component.ts 100% <100%> (ø) ⬆️
components/date-picker/range-picker.component.ts 100% <100%> (ø) ⬆️
components/date-picker/week-picker.component.ts 100% <100%> (ø) ⬆️
components/date-picker/month-picker.component.ts 100% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0a191a...9462ebd. Read the comment docs.

@vthinkxie
Copy link
Member

ref angular/angular#32431

@wenqi73 wenqi73 force-pushed the datepicker-structure branch 4 times, most recently from 5da8e2c to 2387383 Compare March 18, 2020 04:29
fix: build error
@vthinkxie vthinkxie merged commit b567539 into NG-ZORRO:master Mar 18, 2020
@wenqi73 wenqi73 deleted the datepicker-structure branch April 2, 2020 10:46
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…G-ZORRO#4898)

* refactor(module:date-picker): use directive instead of extends class

build: fix build

* build: fix build

fix: build error
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…G-ZORRO#4898)

* refactor(module:date-picker): use directive instead of extends class

build: fix build

* build: fix build

fix: build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants