Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): support disable the esc key to close #567

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #285

What is the new behavior?

When the [nzMaskClosable] or maskClosable is false, disable the esc key

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

考虑到实际使用场景,通过 maskClosable 同时控制蒙层及esc的行为,就像 ant-react 和 material-angular 一样。

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.287% when pulling edf8e68 on HsuanXyz:feature-modal-esc into 35112e8 on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 75bc6b6 into NG-ZORRO:master Nov 16, 2017
@hsuanxyz hsuanxyz deleted the feature-modal-esc branch December 6, 2017 11:33
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants