Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(packaging): generate sourcemaps #666

Merged
merged 1 commit into from
Dec 6, 2017
Merged

feat(packaging): generate sourcemaps #666

merged 1 commit into from
Dec 6, 2017

Conversation

trotyl
Copy link
Contributor

@trotyl trotyl commented Dec 2, 2017

Closes #662
BREAKING CHANGE: umd file name simplified from 'ng-zorro-antd.js' to 'antd.js'

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: closes #662

What is the new behavior?

Change summary:

Does this PR introduce a breaking change?

[x] Yes
[ ] No

The file name of umd bundle changed from ng-zorro-antd.umd[.min].js to antd[.min].js, the prefix is unnecessary in file name.

Other information

@trotyl trotyl changed the title [WIP] feat(packaging): generate sourcemaps feat(packaging): generate sourcemaps Dec 2, 2017
@trotyl trotyl changed the title feat(packaging): generate sourcemaps [WIP] feat(packaging): generate sourcemaps Dec 2, 2017
Closes #662
BREAKING CHANGE: umd file name simplified from 'ng-zorro-antd.js' to 'antd.js'
@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.715% when pulling f6eda69 on trotyl:source-map into 9073bc8 on NG-ZORRO:master.

@trotyl trotyl changed the title [WIP] feat(packaging): generate sourcemaps feat(packaging): generate sourcemaps Dec 2, 2017
@trotyl
Copy link
Contributor Author

trotyl commented Dec 2, 2017

Ready for review.

@NG-ZORRO NG-ZORRO deleted a comment from coveralls Dec 2, 2017
@vthinkxie
Copy link
Member

vthinkxie commented Dec 5, 2017

why not keep the original name ng-zorro-antd.js, it may confuse the users that the same name with react version.

@trotyl
Copy link
Contributor Author

trotyl commented Dec 5, 2017

Whoever use the umd file must specify the npm package name like:

  • <script src="https://unpkg.com/ng-zorro-antd@0.6.2/bundles/antd.umd.js">
  • require('ng-zorro-antd/bundles/antd.umd.js')

It will always be a duplication, isn't it?

@vthinkxie
Copy link
Member

ok, that is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build: publish sourcemap in release
3 participants