Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(module:icon): support upload image to search icon (#5170) #6931

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

ywager
Copy link
Contributor

@ywager ywager commented Aug 20, 2021

close #5170

Same as [1], on the icon page, support to quickly find the icons
that users may find through upload or paste icon.

[1] https://ant.design/components/icon-cn

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x]  No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Aug 20, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 20, 2021

Codecov Report

Merging #6931 (bdc24e0) into master (77db914) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6931      +/-   ##
==========================================
- Coverage   91.67%   91.66%   -0.01%     
==========================================
  Files         486      486              
  Lines       15868    15868              
  Branches     2587     2587              
==========================================
- Hits        14547    14546       -1     
- Misses       1007     1008       +1     
  Partials      314      314              
Impacted Files Coverage Δ
components/core/util/text-measure.ts 92.10% <0.00%> (-0.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77db914...bdc24e0. Read the comment docs.

@simplejason
Copy link
Member

simplejason commented Dec 17, 2021

Hi @ywager, this PR has conflicts that must be resolved, and icon search does not work with nz-upload in your PR, do you mind if I would change some codes in your PR? (or you can rebase from master first)

ywager and others added 2 commits December 29, 2021 22:34
Same as [1], on the icon page, support to quickly find the icons
that users may find through upload or paste icon.

[1] https://ant.design/components/icon-cn
docs(module:icon): fix upload error

docs(module:icon): fix undefined variable
Copy link
Member

@simplejason simplejason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: support upload image to search icon
3 participants