Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change to host class binding #7148

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

yangjunhan
Copy link
Contributor

close #7145

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: 7145

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Dec 23, 2021

This preview will be available after the AzureCI is passed.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #7148 (364523a) into master (7c11bb1) will decrease coverage by 0.00%.
The diff coverage is 90.24%.

❗ Current head 364523a differs from pull request most recent head 400a909. Consider uploading reports for the commit 400a909 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7148      +/-   ##
==========================================
- Coverage   91.68%   91.67%   -0.01%     
==========================================
  Files         486      486              
  Lines       15954    15868      -86     
  Branches     2589     2587       -2     
==========================================
- Hits        14627    14547      -80     
+ Misses       1013     1007       -6     
  Partials      314      314              
Impacted Files Coverage Δ
components/avatar/avatar.component.ts 100.00% <ø> (ø)
components/badge/badge.component.ts 100.00% <ø> (ø)
components/badge/ribbon.component.ts 33.33% <0.00%> (+3.33%) ⬆️
components/button/button.component.ts 98.57% <ø> (-0.03%) ⬇️
components/card/card.component.ts 92.85% <ø> (-0.48%) ⬇️
components/checkbox/checkbox-group.component.ts 100.00% <ø> (ø)
components/checkbox/checkbox.component.ts 98.43% <ø> (-0.03%) ⬇️
components/collapse/collapse-panel.component.ts 92.59% <ø> (-0.52%) ⬇️
components/collapse/collapse.component.ts 95.00% <ø> (-0.24%) ⬇️
components/grid/row.directive.ts 100.00% <ø> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c11bb1...400a909. Read the comment docs.

@hsuanxyz hsuanxyz merged commit c177558 into NG-ZORRO:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor host classname binding
2 participants