Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(module:table): update multiple-sorter.ts #7353

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

notthewaquar
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Apr 7, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #7353 (d7e4be4) into master (b517bd4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master    #7353    +/-   ##
========================================
  Coverage   91.62%   91.62%            
========================================
  Files         487      487            
  Lines       16013    16013            
  Branches     2604     2470   -134     
========================================
  Hits        14672    14672            
  Misses       1027     1027            
  Partials      314      314            

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b517bd4...d7e4be4. Read the comment docs.

@simplejason
Copy link
Member

This is the expected behavior, we expect name not to be sorted. Reference is made to ant-design demo.
The correct behavior should be to hide the sort button when there is no sort(nzSortFn & nzSortPriority)

@simplejason simplejason merged commit aec94c9 into NG-ZORRO:master Sep 26, 2022
chenc041 pushed a commit to chenc041/ng-zorro-antd that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants