-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: deprecated InputBoolean, InputNumber and InputCssPixel #8487
refactor: deprecated InputBoolean, InputNumber and InputCssPixel #8487
Conversation
This preview will be available after the AzureCI is passed. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8487 +/- ##
==========================================
- Coverage 91.56% 91.51% -0.06%
==========================================
Files 532 535 +3
Lines 18337 18424 +87
Branches 2803 2814 +11
==========================================
+ Hits 16790 16860 +70
- Misses 1229 1245 +16
- Partials 318 319 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM:)
WIP |
f1088a4
to
f4df9ce
Compare
1f07e94
to
19869a3
Compare
围观 ing 🍉 |
a8dce6b
to
4a9d345
Compare
4a9d345
to
286051d
Compare
I did it 🥹 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fancy work but partially approved, we should be careful to use numberAttributeZeroFallback
87df1bb
to
1369b5e
Compare
1369b5e
to
9b41fc2
Compare
LGTM |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information