Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:select): support nzOptionHeightPx in global config #8504

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

xunjianxiang
Copy link
Contributor

@xunjianxiang xunjianxiang commented Apr 17, 2024

Fixes #8503

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #8503

What is the new behavior?

we can config nzOptionHeightPx in global config

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

zorro-bot bot commented Apr 17, 2024

This preview will be available after the AzureCI is passed.

@xunjianxiang xunjianxiang mentioned this pull request Apr 17, 2024
3 tasks
Copy link
Collaborator

@HyperLife1119 HyperLife1119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WDYT? @Laffery

@HyperLife1119
Copy link
Collaborator

Related to #8361.

@OriginRing
Copy link
Collaborator

方便为nzOptionHeightPx补齐demo和测试吗

@xunjianxiang
Copy link
Contributor Author

方便为nzOptionHeightPx补齐demo和测试吗

看到之前并没有这方面的测试,而且现有功能都比较稳定。全局配置的机制也有对应的单元测试,仅仅是从配置中进行提取一下,感觉无需为此次 PR 单独编写测试。

至于 nzOptionHeightPx 功能本身的demo 和测试,可以稍后再开一个 pr 进行提交.

@OriginRing
Copy link
Collaborator

LGTM

@OriginRing OriginRing merged commit 4efc5ab into NG-ZORRO:master Apr 19, 2024
7 checks passed
@xunjianxiang xunjianxiang deleted the xunjianxiang/issue8503 branch April 19, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

select 支持全局配置 nzOptionHeightPx
3 participants