Add GeofenceMessage to gcs-vehicles-messages.md #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before looking at the changes, lets do the following changes:
|
rSchwartz1
changed the title
rSchwartz1
force-pushed
the
rSchwartz1-patch-1
branch
from
5696064
to
088857d
Compare
|
Lets do the following changes to the PR
|
Luis729
requested changes
Mar 9, 2020
rSchwartz1
force-pushed
the
rSchwartz1-patch-1
branch
3 times, most recently
from
3c2acfa
to
4e86e25
Compare
Luis729
requested changes
Mar 10, 2020
rSchwartz1
force-pushed
the
rSchwartz1-patch-1
branch
3 times, most recently
from
db1c1a6
to
290ef05
Compare
Why is the change being made? This change is made because GCS needs a new message to handle Geofencing information outside of the start message. This change is not necessary, but it improves scalability for future use of GCS. What has changed to address the problem? This change created a new GeofenceMessage containing geofencing values that can be sent to all vehicles. StartMessage was changed as well by deleting the geofencing parameters that was in it previously. How was this change tested? This change was tested using npm test.
rSchwartz1
force-pushed
the
rSchwartz1-patch-1
branch
from
290ef05
to
0db9325
Compare
Luis729
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why is the change being made?
This change is made because GCS needs a new message to handle Geofencing information outside of the start message. This change is not necessary, but it improves scalability for future use of GCS.
What has changed to address the problem?
This change created a new GeofenceMessage containing geofencing values that can be sent to all vehicles. StartMessage was changed as well by deleting the geofencing parameters that was in it previously.
How was this change tested?
This change was tested using
npm test.