You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the FATES side there is handling of solar radiation error that needs attention and discussion. This issue will act as a prompt, so that we address this part of the FATES code. tagging @ckoven@rosiealice@rgknox@jenniferholm@adrifoster@mpaiao (but all are welcome to comment!) The whole section within SurfaceAlbedoMod devoted to conservation check needs thorough discussion and review, but there is a section where the error appears to be added back onto the albedo (second linked section below here).
This issue was referenced in a SE call today, and we discussed that the radiation code in general would benefit from an overall refactoring, potential update to variables names and a stand alone unit test.
FATES has consistently been producing radiation warning messages that end up producing very large logs. (see these issues: #236 #191 #772) A PR was introduced to reduce unnecessary log messages here: (#792) In review of this PR792 it became apparent that one of the most consistent warnings for a "BalanceCheck on solar radiation" is triggered outside of FATES here in CTSM: https://github.com/ESCOMP/CTSM/blob/bb3d227887b551c8d4e71bc1473753231bbdeb54/src/biogeophys/BalanceCheckMod.F90#L924-L934
On the FATES side there is handling of solar radiation error that needs attention and discussion. This issue will act as a prompt, so that we address this part of the FATES code. tagging @ckoven @rosiealice @rgknox @jenniferholm @adrifoster @mpaiao (but all are welcome to comment!) The whole section within SurfaceAlbedoMod devoted to conservation check needs thorough discussion and review, but there is a section where the error appears to be added back onto the albedo (second linked section below here).
fates/biogeophys/EDSurfaceAlbedoMod.F90
Lines 916 to 925 in 2fa452a
Here is a link to that specific section of the code with comments on the error handling that was noted in PR792:
fates/biogeophys/EDSurfaceAlbedoMod.F90
Lines 968 to 988 in 2fa452a
The text was updated successfully, but these errors were encountered: