Skip to content
This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

hwmonN sensor paths can change #12

Open
Alia5 opened this issue Feb 21, 2023 · 1 comment
Open

hwmonN sensor paths can change #12

Alia5 opened this issue Feb 21, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Alia5
Copy link

Alia5 commented Feb 21, 2023

As seen in https://github.com/NGnius/Fantastic/blob/main/backend-rs/src/sys.rs, the paths to the sensors are hardcoded to .../hwmon5/...

This really isn't ideal as hwmon indices aren't fixed but dependent on module loading order and thus may change on reboot.
(For me personally fan1_input isn in hwmon4 so I cannot really use this Fantastic (pun intended) plugin)

To fix this, the index should be queried dynamically instead of being hardcoded

@NGnius
Copy link
Owner

NGnius commented Feb 22, 2023

From my experience, module load order is consistent on Steam Deck so this is good enough. If you're using a different kernel or a completely different system then it's going to break but then that's fine since Fantastic only supports SteamOS 3 on Steam Deck right now.

@NGnius NGnius added the enhancement New feature or request label Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants