Application destination directory and name

[aistrych]

Why application on Linux is packaged into additional appname/core directories and why application binary name is not appname but the name of Julia file containing julia_main function? I think it makes sense for MacOS platform but not so much on Linux/Windows.

Why the builddir directory is put inside the same directory julia_main function file is located? For example build_app_bundle executed like this:

build_app_bundle("src/App.jl", appname="app", builddir="build")

put build directory inside src one which is not very intuitive I would say.

[NHDaly]

Yeah, if you think that would be better, let's change it! :)

Would you be able to open a PR?

[aistrych]

I think I can. Julia is a relatively new language for me but it's fun so I think I will manage :)

[aistrych]

Small update: I still plan to do that I was just very busy lately. I think I will be able to look on it this weekend.

[NHDaly]

#48 has addressed all of these concerns! :)

The linux/windows build has been changed to write to $appname/bin/$binary_name. The binary_name defaults to your script's basename, but can be changed via a flag.

ApplicationBuilder.jl/src/bundle.jl

Line 10 in 896e541

binary_name = splitext(basename(juliaprog_main))[1],

The buildpath is now understood to be relative to cwd, as paths usually are on the command line:

ApplicationBuilder.jl/src/bundle.jl

Lines 19 to 21 in 896e541

	juliaprog_main = abspath(juliaprog_main)
	builddir = abspath(builddir)
	builddir = joinpath(builddir, appname)

ApplicationBuilder.jl/src/bundle.jl

Line 25 in 896e541

core_path = joinpath(builddir, "bin")

https://github.com/NHDaly/ApplicationBuilder.jl/pull/48/files#diff-c124f08b6e3c986fc3a10e09702f0f01L13

thanks for bringing up these issues @Astrych! :)

[NHDaly]

(I'm next going to unify the mac and linux/windows codebases in #51)

[aistrych]

@NHDaly Oh. I forgot about that issue XD Sorry. Great that you have fixed it!

[NHDaly]

Haha me too tbh. Until I needed to start building for Linux. ;) Thanks! Nathan.

…

On Wed, Apr 17, 2019, 5:33 AM Astrych ***@***.***> wrote: @NHDaly <https://github.com/NHDaly> Oh. I forgot about that issue XD Sorry. Great that you have fixed it! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#42 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABgkEcydRy6Q6NKrvfZCUVy5vKfZrLHIks5vhupvgaJpZM4a7Rai> .