Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commandline_app flag for Apps without a GUI. On Mac, this will create an App bundle which simply opens a Terminal and runs your code. I *believe* that on Windows, there's nothing special to be done; I think it will Just Work like this by default. #17

Merged
merged 3 commits into from Jul 22, 2018
Merged

Add commandline_app flag for Apps without a GUI. On Mac, this will create an App bundle which simply opens a Terminal and runs your code. I *believe* that on Windows, there's nothing special to be done; I think it will Just Work like this by default. #17

merged 3 commits into from Jul 22, 2018

Conversation

NHDaly
Copy link
Owner

@NHDaly NHDaly commented Jul 21, 2018 •
edited

This fixes Issue #16.

  • Verify this on windows before submitting.

@NHDaly
Add commandline_app flag for Apps without a GUI.
78c42fa 
On Mac, this will create an App bundle which simply opens a Terminal and
runs your code.

I *believe* that on Windows, there's nothing special to be done; I think
it will Just Work like this by default.
@codecov-io
Copy link

codecov-io commented Jul 21, 2018 •
edited

Codecov Report

Merging #17 into master will increase coverage by 2.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   54.48%   56.96%   +2.48%     
==========================================
  Files           5        6       +1     
  Lines         156      165       +9     
==========================================
+ Hits           85       94       +9     
  Misses         71       71
Impacted Files Coverage Δ
src/mac_commandline_app.jl 100% <100%> (ø)
src/BuildApp.jl 87.87% <100%> (+0.24%) ⬆️
src/bundle.jl 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5c33a3...42b2b19. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 21, 2018 •
edited

Pull Request Test Coverage Report for Build 89

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.5%) to 56.97%
Totals Coverage Status
Change from base Build 87: 2.5%
Covered Lines: 94
Relevant Lines: 165
💛 - Coveralls

@NHDaly
Copy link
Owner Author

NHDaly commented Jul 22, 2018

Yep, verified that Windows handles commandline-only applications correctly by default! :)

@NHDaly NHDaly merged commit 0b7154b into master Jul 22, 2018
@NHDaly NHDaly deleted the commandline_app branch July 22, 2018 16:49
NHDaly added a commit that referenced this pull request Jul 22, 2018
@NHDaly
Merge pull request #17 from NHDaly/commandline_app
1cfb2da 
Add `commandline_app` flag for Apps without a GUI.

On Mac, this will create an App bundle which simply opens a Terminal and
runs your code.  On Windows, there's nothing special to be done.  It
will Just Work like this by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NHDaly @codecov-io @coveralls