Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick boxes when specimen or label obscured #445

Closed
6 of 13 tasks
PipBrewer opened this issue Oct 26, 2023 · 14 comments
Closed
6 of 13 tasks

Tick boxes when specimen or label obscured #445

PipBrewer opened this issue Oct 26, 2023 · 14 comments
Assignees
Labels
1 priority 1 backend backend frontend Improvements or additions to the frontend / UI. new feature post-processing Specimen table export preparation for import using OpenRefine Requires consultation UI UI-tested UI testing done by installing the app and trying to replicate the bug

Comments

@PipBrewer
Copy link
Collaborator

PipBrewer commented Oct 26, 2023

Some discussion has been going on with the collection managers and digitisers, but it looks like we should make a note of instances in the Digi App where the specimens and/or label will not be able to be imaged as they are obscured (has implications for reports to collection managers, status and for transcription). In Specify, I was thinking that if we add them as separate lines in the remarks table using controlled terminology, we should be able to run reports on them to send to collection managers to review. However, in the App it might be easiest to have tick boxes for these.

  • @chelseagraham and Matilde to confirm with Jens S regarding the use of "Specimen obscured" and "Label Obscured" and provide a link here to that ticket with examples of how we use it and why.
  • Decide where in UI boxes will go and what will look like
  • Hand over to DigiApp team to implement
  • Fedor to review the below steps and add additional/edit as needed
  • Create tick box in UI for "Specimen Obscured"
  • Create tick box in UI for "Label Obscured"
  • Create columns for each of the tick boxes in the specimen table in the db
  • These should then map to separate lines in the Remarks table in Specify and so need to update GREL script (how do we do this?)
  • Fully test
  • Demonstrate to Chelsea
  • Update user documentation
  • Update GREL documentation
  • Update App documentation
@PipBrewer PipBrewer created this issue from a note in Mass Digitization App (Upcoming Sprints) Oct 26, 2023
@PipBrewer
Copy link
Collaborator Author

PipBrewer commented Oct 26, 2023

Sent email on 26/10/2023 to Fedor, Bhupjit and Jan asking whether it is theoretically possible to map notes from DigiApp to different lines in Remarks table in Specify.

Fedor's response: "Yes. If data like “Specimen Obscured” are separate tickboxes (or other kinds of input fields) that are stored into individual columns in the local app db then these can be sorted into columns that can be mapped to individual “Remarks” records (in reality: Collection Object Properties) associated with each specimen."

@PipBrewer PipBrewer added frontend Improvements or additions to the frontend / UI. backend backend post-processing Specimen table export preparation for import using OpenRefine 1 priority 1 new feature UI UI-tested UI testing done by installing the app and trying to replicate the bug Requires consultation labels Oct 26, 2023
@chelseagraham
Copy link
Collaborator

just linking a ticket on the Herbarium board from which I can draw information relevant to this ticket NHMDenmark/Herbarium-Sheets-workstation#55

@chelseagraham
Copy link
Collaborator

chelseagraham commented Jan 19, 2024

@Gomismis as per our meeting with Pip, please add decisions (from NHMDenmark/Herbarium-Sheets-workstation#55) here, re-assign this ticket to Bhupjit, and then take this ticket off of our project board. Thank you.

@chelseagraham chelseagraham removed their assignment Jan 19, 2024
@chelseagraham
Copy link
Collaborator

chelseagraham commented Feb 2, 2024

Current procedures (from @Gomismis document NHMDenmark/Herbarium-Sheets-workstation#55) include

  • Flagging a specimen with visible labels and obscured or missing specimens as an MSO and scanning a data matrix with the controlled vocabulary "Specimen obscured" into the notes field. The number of barcode labels assigned corresponds to the number of visible labels. A single image is taken. (1.2, 1.6, 1.8, 4.1, 4.4)
  • Flagging a specimen with obscured labels and obscured specimens as an MSO and scanning a data matrix with the controlled vocabulary "Specimen obscured; Label obscured" into the notes field. A single barcode is assigned. A single image is taken. (1.3)
  • Entering a specimen with layered specimens and all information on the bottom sheet as a single specimen (no radio buttons selected) and scanning a data matrix with the controlled vocabulary "Specimen obscured; Label obscured" into the notes field. A single barcode is assigned. A single image is taken. (1.4, 1.7)
  • Entering a specimen with layered specimens and the same label information as a single specimen (no radio buttons selected) and scanning a data matrix with the controlled vocabulary "Specimen obscured" into the notes field. A single barcode is assigned. A single image is taken. (1.5)
  • Entering a specimen with label obscured as a single specimen (no radio buttons selected) and scanning a data matrix with the controlled vocabulary "Label obscured" into the notes field. A single barcode is assigned. A single image is taken. (1.7)
  • Entering photos and drawings with associated data and scanning a data matrix with the controlled vocabulary "Non-botanical object" into the notes field. The number of barcode labels assigned corresponds to the number of visible labels. A single image is taken. (4.2)

I will just wait until this is confirmed (as the ticket that this is dependent (NHMDenmark/Herbarium-Sheets-workstation#55) on is not closed / completely resolved - needing input from @PipBrewer )

Confirmed by Pip

@chelseagraham chelseagraham self-assigned this Feb 2, 2024
@FedorSteeman FedorSteeman moved this from Upcoming Sprints to Current Sprint in Mass Digitization App Feb 8, 2024
@FedorSteeman FedorSteeman self-assigned this Feb 8, 2024
@FedorSteeman FedorSteeman moved this from Current Sprint to Doing in Mass Digitization App Feb 13, 2024
@FedorSteeman
Copy link
Contributor

@bhsi-snm @PipBrewer Are the requirements of this ticket ready for me to start implementing, or who has the ball on this issue?

@FedorSteeman FedorSteeman removed their assignment Feb 13, 2024
@FedorSteeman FedorSteeman moved this from Doing to Current Sprint in Mass Digitization App Feb 13, 2024
@FedorSteeman
Copy link
Contributor

@chelseagraham What is the status?

@chelseagraham
Copy link
Collaborator

Confirming use of "Label Obscured" and "Specimen Obscured"

@chelseagraham chelseagraham removed their assignment Feb 13, 2024
@FedorSteeman
Copy link
Contributor

@chelseagraham Where on the UI are these two (?) tick boxes to be placed?

@bhsi-snm bhsi-snm assigned bhsi-snm and unassigned bhsi-snm Feb 13, 2024
@FedorSteeman
Copy link
Contributor

Placement specified here:
#439 (comment)

@FedorSteeman
Copy link
Contributor

I just talked with @chelseagraham and I believed that these tickboxes are to be mapped to flag fields. However, looking through the ticket specification I can see these are to be mapped to collection object remarks (properties), so will do that instead.

Teased out the tasks that are relevant to me:

  • Create tick box in UI for "Specimen Obscured"
  • Create tick box in UI for "Label Obscured"
  • Create columns for each of the tick boxes in the specimen table in the db
  • These should then map to separate lines in the Remarks table in Specify

@FedorSteeman FedorSteeman moved this from Current Sprint to Doing in Mass Digitization App Feb 21, 2024
@FedorSteeman FedorSteeman self-assigned this Feb 21, 2024
@FedorSteeman
Copy link
Contributor

FedorSteeman commented Feb 21, 2024

@chelseagraham Should I group these checkboxes together as proposed and use the caption "Specimen Flags" as per below?

image

@chelseagraham
Copy link
Collaborator

I think this works well. As Rebekka mentioned, they are not mutually exclusive, so the check boxes makes the most sense. :)

FedorSteeman added a commit that referenced this issue Feb 22, 2024
New features:
* Rearranged data input fields to a new flow of direction (#439)
* Added tick boxes for specimen obscured and label obscured (#445)
* Added multi-object warning whenever a linked record is created or viewed (#274)
* Enable rank determination of taxon name also when author is added (#484)

The latter feature (#484) requires the end user to separate out the authorship section of a novel taxon name entry using an underscore and an underscore only e.g. "Eriocrana incognita_Schütler 1984". This way the authorship can be taken out before parsing the taxon name in order to determine rank. Rank determination is dependent on a set pattern of space-separated elements of the full binomial or trinomial name.
Mass Digitization App automation moved this from Doing to Done Feb 22, 2024
@AstridBVW AstridBVW self-assigned this Jul 3, 2024
@AstridBVW AstridBVW reopened this Jul 3, 2024
Mass Digitization App automation moved this from Done to Backlog Jul 3, 2024
@AstridBVW
Copy link
Collaborator

This ticket was closed prematurely. Steps were missed, there still need to be made changes to the GREL script and mapping to accommodate the mapping of "Specimen obscured" and "Label obscured" to the DaSSCo remarks table in Specify.

@AstridBVW AstridBVW moved this from Backlog to Doing in Mass Digitization App Jul 3, 2024
AstridBVW added a commit that referenced this issue Jul 3, 2024
Tick boxes for specimenobscured and labelobscured were added to the app. They are to be placed in the DaSSCo remarks table in Specify. The GREL script is now adapted to accommodate this.
@AstridBVW
Copy link
Collaborator

The GREL script has now been updated and pushed to github. It has been set up in a similar fashion to the notes field with a remark, source and date. The remark is "Specimen obscured" and "Label obscured" respectively, the source is "DaSSCo digitisation", and the date is the same as the cataloged date.

The mapping to the remarks table will be added with the next import.

Mass Digitization App automation moved this from Doing to Done Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 priority 1 backend backend frontend Improvements or additions to the frontend / UI. new feature post-processing Specimen table export preparation for import using OpenRefine Requires consultation UI UI-tested UI testing done by installing the app and trying to replicate the bug
Projects
Development

No branches or pull requests

6 participants