getChar uses getString(1). getChar now respects basic ascii

NHQ · Nov 30, 2011 · 870444a · 870444a
1 parent e73f002
commit 870444a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 30 deletions.
diff --git a/src/jdataview.js b/src/jdataview.js
@@ -147,30 +147,7 @@ jDataView.prototype = {
 	},
 
 	getChar: function (byteOffset) {
-		var value, size = 1;
-
-		// Handle the lack of byteOffset
-		if (byteOffset === undefined) {
-			byteOffset = this._offset;
-		}
-
-		if (this._isArrayBuffer || this._isNodeBuffer) {
-			// Use Int8Array and String.fromCharCode to extract a string
-			value = String.fromCharCode(this.getUint8(byteOffset));
-		} else {
-			// Error Checking
-			if (typeof byteOffset !== 'number') {
-				throw new TypeError('Type error');
-			}
-			if (byteOffset + size > this.byteLength) {
-				throw new Error('INDEX_SIZE_ERR: DOM Exception 1');
-			}
-
-			value = this.buffer.charAt(this._start + byteOffset);
-			this._offset = byteOffset + size;
-		}
-
-		return value;
+		return this.getString(1, byteOffset);
 	},
 
 	tell: function () {

diff --git a/test/test.js b/test/test.js
@@ -63,13 +63,13 @@ function chr (x) {
 }
 
 test('Char', function () {
-	equal(view.getChar(0), chr(255));
-	equal(view.getChar(1), chr(254));
-	equal(view.getChar(2), chr(253));
-	equal(view.getChar(3), chr(252));
-	equal(view.getChar(4), chr(250));
+	equal(view.getChar(0), chr(65533));
+	equal(view.getChar(1), chr(65533));
+	equal(view.getChar(2), chr(65533));
+	equal(view.getChar(3), chr(65533));
+	equal(view.getChar(4), chr(65533));
 	equal(view.getChar(5), chr(0));
-	equal(view.getChar(6), chr(186));
+	equal(view.getChar(6), chr(65533));
 	equal(view.getChar(7), chr(1));
 });