Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSARM-8814 DPS CORE REQUEST - To Update of public facing Immunisation… #193

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

helen-brown
Copy link
Contributor

@helen-brown helen-brown commented Sep 8, 2023

… History API based on feedback from Point of Care system providers.

Summary

  • Routine Change

Update of public facing Immunisation History API based on feedback from Point of Care system providers.

Data items that may become excluded as they do not contain the correct data format should not be listed as mandatory
doseQuantity > Value
Accept Header should list both version=1.0 and version=2.0 as options
Update sandbox example data to only included fields and data structure as present in the integration environment (for COVID19).
Also updated the type of doseQuantity > Value as the value returned is a number not an integer.

Tests have been updated to use pytest-nhsd-apim as the old test library is deprecated, and to use mock-auth in internal dev.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

joan-garcia2
joan-garcia2 previously approved these changes Sep 11, 2023
joan-garcia2
joan-garcia2 previously approved these changes Sep 19, 2023
@helen-brown helen-brown force-pushed the feature/DSARM-8814-update-api-documentation branch 24 times, most recently from 3e98ea7 to d932a86 Compare September 22, 2023 15:30
@helen-brown helen-brown force-pushed the feature/DSARM-8814-update-api-documentation branch 24 times, most recently from 5e7812c to fcce9a0 Compare October 3, 2023 09:29
… History API based on feedback from Point of Care system providers.
@helen-brown helen-brown merged commit afee6fb into master Oct 5, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants