Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change font #103

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Change font #103

merged 4 commits into from
Aug 22, 2023

Conversation

toni-santos
Copy link
Collaborator

Closes #11

Change the website font to a something more modern and pleasing.

image

@toni-santos toni-santos self-assigned this Jul 30, 2023
@toni-santos
Copy link
Collaborator Author

Regarding this issue, this seems like all that we need to do. There may, as always, be bugs.

It would also be interesting to allow users to choose their own font, either from a selection made by us, available in the pop-up, or by inputting a font name, that we could then import from Google Fonts, per example. Both of these features warrant some design decisions within the popup, and given the ongoing #98 PR this might not be the best of times to focus on this.

@thePeras
Copy link
Member

thePeras commented Aug 2, 2023

I think there should be an option to enable/disable this feature in the popup.

However, I like the font a loot, it feels more comfort to read.

@toni-santos
Copy link
Collaborator Author

I think there should be an option to enable/disable this feature in the popup.

However, I like the font a loot, it feels more comfort to read.

Just added this option and fixed a small issue on a function in the same file. Please check it out :)

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the popup text more user friendly like "Mudar fonte de letra".

Also, now comparing to the default font, the new one seams to big. There is any possible to decrease the font-size?

Copy link
Member

@ttoino ttoino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a little comment

popup/components/sections/LayoutContent.js Outdated Show resolved Hide resolved
@ttoino
Copy link
Member

ttoino commented Aug 16, 2023

Also, now comparing to the default font, the new one seams to big. There is any possible to decrease the font-size?

IMO it looks fine like this, but we could change the font size on the html element, sigarra uses em for its font sizes thankfully.

Copy link
Member

@ttoino ttoino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just update the branch and this should be good to merge!

@ttoino ttoino merged commit 0491b59 into main Aug 22, 2023
@ttoino ttoino deleted the feature/font branch August 22, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change font
3 participants