Make src/usr/iptables/Makefile respect $DESTDIR #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepend ${DESTDIR} to the destination path in the xtables module
"make install" / "make uninstall" targets, as expected by package
build systems.
|
Oh, yeah... this makefile. I did a pretty lousy job with it, huh? Sorry. I forgot to TODO-tag it after it started working sufficiently for my purposes. Since most of the userspace tools use automake, I would expect this one to follow suit. (Or, at the very least, it should be made to support all the other relevant Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package build scripts often set $DESTDIR in the 'make install' command line to set an alternate destination prefix.
This patch prefixes $DESTDIR to the install destination for the xtables modules.
The other userspace makefiles are generated by automake and so already have this.