New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make src/usr/iptables/Makefile respect $DESTDIR #272

Merged
merged 2 commits into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@paradon
Copy link
Contributor

paradon commented Jan 6, 2019

Package build scripts often set $DESTDIR in the 'make install' command line to set an alternate destination prefix.

This patch prefixes $DESTDIR to the install destination for the xtables modules.

The other userspace makefiles are generated by automake and so already have this.

paradon added some commits Jan 6, 2019

Make src/usr/iptables/Makefile respect $DESTDIR
Prepend ${DESTDIR} to the destination path in the xtables module
"make install" / "make uninstall" targets, as expected by package
build systems.
@ydahhrk

This comment has been minimized.

Copy link
Member

ydahhrk commented Jan 7, 2019

Oh, yeah... this makefile.

I did a pretty lousy job with it, huh? Sorry. I forgot to TODO-tag it after it started working sufficiently for my purposes.

Since most of the userspace tools use automake, I would expect this one to follow suit. (Or, at the very least, it should be made to support all the other relevant make variables: CC, CFLAGS, etc.) But I think it's too late for that kind of refactor. My plan is to merge this pull request and handle the automake treatment later as part of the #264 patch.

Thanks for your work!

@ydahhrk ydahhrk merged commit 23c146f into NICMx:release-candidate-4 Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment