This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
CFURLCreateStringByAddingPercentEscapesの変更 (issue #95) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntEncodingWithAllowedCharacters
ncmbsupport
reviewed
Jul 5, 2017
| [self createSignature]; | ||
| self.path = [self percentEscape:self.path]; | ||
| self.path = [self.path stringByAddingPercentEncodingWithAllowedCharacters:[NSCharacterSet URLPathAllowedCharacterSet]]; |
There was a problem hiding this comment.
Please remove unnecessary space key ( " " / " " )
gs0zk1
added
Waiting For Review
In Review
and removed
in progress
Waiting For Review
labels
|
Connected to #95 |
vfa-duyna
changed the title
gs0zk1
reviewed
Jul 10, 2017
NCMB/NCMBRequest/NCMBRequest.m
Outdated
| CFSTR(":/?#[]@!$&'()*+,;="), | ||
| kCFStringEncodingUTF8 ); | ||
| NSString *escapedStr = CFBridgingRelease(escapedStrRef); | ||
| NSString * escapedStr = [originalString stringByAddingPercentEncodingWithAllowedCharacters:[[NSCharacterSet characterSetWithCharactersInString:@":/?#[]@!$&'()*+,;=\"<>\^`{|}"] invertedSet]]; |
There was a problem hiding this comment.
*とescapedStrの間のspaceも削除してください
gs0zk1
reviewed
Jul 21, 2017
| @@ -78,13 +78,7 @@ +(NSString *)returnSessionToken { | |||
| } | |||
|
|
|||
| +(NSString *)returnEncodedString:(NSString *)originalString { | |||
There was a problem hiding this comment.
このメソッドのテストをNCMBTests/NCMBRequestSpec.mに追加してください。
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Summary)
動作確認手順(Step for Confirmation)
Run the unit test.