Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

issue #136 warning deprecated UIAlertView on ios 10 #220

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

vfa-thanhnh
Copy link
Contributor

SDKの改善にご協力いただきありがとうございます。
(Thank you for your support our SDK.)

プルリクエストを作成する場合は、developをターゲットにしてください。
(Please select target branch to "develop" branch.)

可能な限り、修正時にはテストコードまたは動作確認手順を追加してください。
(Please include test code or describe confirmation steps as possible.)

概要(Summary)

動作確認手順(Step for Confirmation)

Run the unit test.

Copy link
Contributor

@vfa-tamhh vfa-tamhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is OK!

Copy link
Contributor

@ncmbadmin ncmbadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「動作確認待ち」本件修正内容をコードレビューしました、問題がないと思います。
プッシュ通知(OS10以降)動作確認については実施中のため、再度更新します。

@kobo0908
Copy link
Contributor

動作問題ないありませんのでmegeいたします。

@kobo0908 kobo0908 merged commit 7abde91 into develop Sep 25, 2020
@kobo0908 kobo0908 deleted the fix/remove_ui_alert_view branch September 25, 2020 01:05
@kobo0908 kobo0908 mentioned this pull request Jan 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants