This repository has been archived by the owner on Apr 1, 2024. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thuydg
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2点コメントがありますので、ご確認をお願いいたします
README.md
Outdated
@@ -19,7 +19,7 @@ For SDK installation steps, see [Quick Start](https://mbaas.nifcloud.com/doc/cu | |||
|
|||
| Environment | Supported version | | |||
|:--- |:--- | | |||
| Node.js | 14.x, 16.x, 18.x | | |||
| Node.js | 16.x, 18.x, 20.x | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
以下によりNode16もEOLになっていたため、サポート対象から外せばなと思います。
合わせてworkflowの検証環境も更新いただけますでしょうか。
https://nodejs.org/en/blog/announcements/nodejs16-eol
thuydg
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
更新内容を確認しました。問題がありません。
Merged
watanabe-tomoya
pushed a commit
that referenced
this pull request
Oct 16, 2023
* Node 20.x 対応 (#317) * Add node 20.x to workflow * Bump actions/checkout to v4 * Remove node 14.x on workflows * Fix to use npm-ci on workflows * Revert "Fix to use npm-ci on workflows" This reverts commit e2344a1. * Add npm matrix to worklflows * Update npm version on workflows * Update supported node version * Remove node14,16 * Update npm worflow * Bump/v3.3.0 (#319) * Bump version to v3.3.0 * Update LICENSE * Replace with new ncmb.min.js --------- Co-authored-by: dinh.thuy.duong <dinh.thuy.duong@fujitsu.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary