Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

Node 20.x 対応 #317

Merged
merged 9 commits into from Oct 3, 2023
Merged

Node 20.x 対応 #317

merged 9 commits into from Oct 3, 2023

Conversation

harapekokoro
Copy link
Contributor

@harapekokoro harapekokoro commented Sep 29, 2023

Summary

  • Node 20.x を対応環境に含める
  • EOLのためNode 14.x, 16.xを対応環境から除外
  • ワークフロー更新

@harapekokoro harapekokoro changed the base branch from master to develop September 29, 2023 06:06
Copy link
Contributor

@thuydg thuydg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2点コメントがありますので、ご確認をお願いいたします

README.md Show resolved Hide resolved
README.md Outdated
@@ -19,7 +19,7 @@ For SDK installation steps, see [Quick Start](https://mbaas.nifcloud.com/doc/cu

| Environment | Supported version |
|:--- |:--- |
| Node.js | 14.x, 16.x, 18.x |
| Node.js | 16.x, 18.x, 20.x |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以下によりNode16もEOLになっていたため、サポート対象から外せばなと思います。
合わせてworkflowの検証環境も更新いただけますでしょうか。
https://nodejs.org/en/blog/announcements/nodejs16-eol

Copy link
Contributor

@thuydg thuydg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

更新内容を確認しました。問題がありません。

@thuydg thuydg merged commit a476e24 into develop Oct 3, 2023
2 checks passed
@thuydg thuydg deleted the feature/node_20 branch October 3, 2023 01:00
@harapekokoro harapekokoro mentioned this pull request Oct 11, 2023
watanabe-tomoya pushed a commit that referenced this pull request Oct 16, 2023
* Node 20.x 対応 (#317)

* Add node 20.x to workflow

* Bump actions/checkout to v4

* Remove node 14.x on workflows

* Fix to use npm-ci on workflows

* Revert "Fix to use npm-ci on workflows"

This reverts commit e2344a1.

* Add npm matrix to worklflows

* Update npm version on workflows

* Update supported node version

* Remove node14,16

* Update npm worflow

* Bump/v3.3.0 (#319)

* Bump version to v3.3.0

* Update LICENSE

* Replace with new ncmb.min.js

---------

Co-authored-by: dinh.thuy.duong <dinh.thuy.duong@fujitsu.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants