Change CLI naming convention and update documentation #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatry
added this to In progress
in C API & command line tool to manage PSA-eBPF programs
via automation
tatry
force-pushed
the
tatry/documentation
branch
3 times, most recently
from
0ee001e
to
1236c47
Compare
osinstom
requested changes
May 20, 2022
docs/command reference.md
Outdated
| ```shell | ||
| psabpf-ctl digest get pipe ID DIGEST | ||
|
|
||
| DIGEST := { id DIGEST_ID | name FILE | DIGEST_FILE } |
There was a problem hiding this comment.
It'd be good to explain what is DIGEST_ID and DIGEST_FILE. This comment applies to all other commands too.
Also, it would be useful to explain what is the name format as a P4 developer may try to use extern name defined as defined in a P4 language while we require <Pipeline>_<extern name>, right? As this applies to all externs/objects, we can add such a note at the beginning of this document.
tatry
force-pushed
the
tatry/documentation
branch
from
f31fb5f
to
2bbdab1
Compare
|
PTF tests available in tatry/p4c#7 |
osinstom
changed the title
osinstom
approved these changes
May 23, 2022
C API & command line tool to manage PSA-eBPF programs
automation
moved this from In progress
to Done
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.