Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build does not work with newer CMake on Windows #56

Closed
sjh26 opened this issue Apr 23, 2020 · 4 comments · Fixed by #54
Closed

Windows build does not work with newer CMake on Windows #56

sjh26 opened this issue Apr 23, 2020 · 4 comments · Fixed by #54

Comments

@sjh26
Copy link
Contributor

sjh26 commented Apr 23, 2020

If #55 is worked-around by setting the Fortran compiler environment variable in SPHARM-PDM's CMakeLists, this error occurs when building using CMake 3.15.1:

-- Detecting Fortran/C Interface
  CMake Error in C:/cmake-3.15.1/share/cmake-3.15/Modules/FortranCInterface/CMakeLists.txt:
    MSVC_RUNTIME_LIBRARY value 'MultiThreadedDLL' not known for this Fortran
    compiler.
  
  
  CMake Error at C:/cmake-3.15.1/share/cmake-3.15/Modules/FortranCInterface/Detect.cmake:31 (try_compile):
    Failed to generate test project build system.
  Call Stack (most recent call first):
    C:/cmake-3.15.1/share/cmake-3.15/Modules/FortranCInterface.cmake:224 (include)
    LAPACKE/CMakeLists.txt:7 (include)
  
  
  -- Configuring incomplete, errors occurred!

This does not occur in the SlicerSALT factory build, which uses CMake 3.13.4

@sjh26
Copy link
Contributor Author

sjh26 commented Apr 28, 2020

So, I was able to test this with CMake 3.16.3, and it did work. So maybe we just need to update the CMake on the factory.

@jcfr
Copy link
Contributor

jcfr commented Apr 28, 2020

So maybe we just need to update the CMake on the factory

That seems reasonable.

Did we try to update before and had to roll back ?

@sjh26
Copy link
Contributor Author

sjh26 commented Apr 30, 2020

Yeah. I forget what broke, though. Also we were still updating with 3.15

@jcfr jcfr linked a pull request Apr 29, 2022 that will close this issue
@jcfr
Copy link
Contributor

jcfr commented Apr 29, 2022

Closing. This issue is obsolete and fixes have already been integrated.

@jcfr jcfr closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants