This repository has been archived by the owner on Nov 26, 2019. It is now read-only.
forked from akshatnitd/IMDB_Portal
-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshatnitd
reviewed
Dec 3, 2018
imdb.py
Outdated
|
||
|
||
def info_movie(): | ||
name = raw_input('\nEnter the title of the movie: ') | ||
t = name.replace(' ','%20') | ||
url = 'https://api.themoviedb.org/3/search/movie?api_key=ffb07b773769d55c36ccd83845385205&language=en-US&query='+str(t)+'&page=1&include_adult=false' | ||
web_name = name.replace(' ', '%20') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it movie_name
imdb.py
Outdated
t = name.replace(' ','%20') | ||
url = 'https://api.themoviedb.org/3/search/movie?api_key=ffb07b773769d55c36ccd83845385205&language=en-US&query='+str(t)+'&page=1&include_adult=false' | ||
web_name = name.replace(' ', '%20') | ||
url = 'https://api.themoviedb.org/3/search/movie?api_key=ffb07b773769d55c36ccd83845385205&language=en-US&query=' + str(web_name) + '&page=1&include_adult=false' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Write meaningful names for url
and url2
imdb.py
Outdated
u = json.loads(response.text) | ||
results = u['results'] | ||
results_json = json.loads(response.text) | ||
results = results_json['results'] | ||
id = results[0]['id'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
movie_id
imdb.py
Outdated
duration = details['runtime'] | ||
plot = details['overview'] | ||
|
||
url3 = 'http://www.imdb.com/title/' + str(imdb_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename it
@akshatnitd This PR got accidentally closed while rebasing. I just can't understand how. I will send a new PR soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Changes: