Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some transforms modules, pre and post transforms, update transforms config #235

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

georgeyiasemis
Copy link
Contributor

  • Some transforms are now nn.Modules and can be implemented batch-wise
  • MRI transforms split to pre-transforms and post-transforms. Plan is to call pre-transforms before collation and post-transforms after collation on device [not implemented yet, functionality now is as it was].
  • Adding augmentation transforms: RandomFlip and RandomRotation
  • Updates transforms configuration by flattening DictConfig from omegaconf

@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Patch coverage: 87.61% and project coverage change: -0.01 ⚠️

Comparison is base (28d05d5) 83.88% compared to head (d596c08) 83.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
- Coverage   83.88%   83.87%   -0.01%     
==========================================
  Files          91       91              
  Lines        6136     6276     +140     
==========================================
+ Hits         5147     5264     +117     
- Misses        989     1012      +23     
Impacted Files Coverage Δ
direct/data/mri_transforms.py 92.47% <83.85%> (-4.68%) ⬇️
direct/algorithms/mri_algorithms.py 100.00% <100.00%> (ø)
direct/data/datasets_config.py 100.00% <100.00%> (ø)
direct/train.py 56.93% <100.00%> (ø)
direct/types.py 84.37% <100.00%> (+1.04%) ⬆️
direct/utils/__init__.py 77.63% <100.00%> (+2.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions github-actions bot added the ci label Feb 1, 2023
direct/types.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please immediately make an issue for black, and a PR.

@jonasteuwen jonasteuwen merged commit 2968f49 into main Mar 13, 2023
@jonasteuwen jonasteuwen deleted the update-transforms branch March 13, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants