Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds transforms for 3D data #272

Merged
merged 34 commits into from
Mar 27, 2024
Merged

Adds transforms for 3D data #272

merged 34 commits into from
Mar 27, 2024

Conversation

georgeyiasemis
Copy link
Contributor

This PR:

  • Reformats some mri transforms to operate for both 2D and 3D data
  • Adds random reverse (slice or time dimension) transform
  • Edits 2D mri model losses to be computed per batch and slice/time for 3D data
  • Tests for new functionality
  • Updates readme file

@georgeyiasemis georgeyiasemis self-assigned this Mar 27, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python labels Mar 27, 2024
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 72.97297% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 84.05%. Comparing base (05cb54f) to head (c2d3baf).

❗ Current head c2d3baf differs from pull request most recent head f4c9bf5. Consider uploading reports for the commit f4c9bf5 to get more accurate results

Files Patch % Lines
direct/nn/mri_models.py 39.28% 34 Missing ⚠️
direct/data/mri_transforms.py 95.77% 3 Missing ⚠️
direct/engine.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #272      +/-   ##
==========================================
- Coverage   84.34%   84.05%   -0.29%     
==========================================
  Files          95       95              
  Lines        6631     6743     +112     
==========================================
+ Hits         5593     5668      +75     
- Misses       1038     1075      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jonasteuwen jonasteuwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small remarks

direct/engine.py Outdated Show resolved Hide resolved
direct/engine.py Outdated Show resolved Hide resolved
direct/utils/__init__.py Outdated Show resolved Hide resolved
direct/data/mri_transforms.py Show resolved Hide resolved
tests/tests_nn/test_rim_engine.py Outdated Show resolved Hide resolved
@jonasteuwen jonasteuwen merged commit b660012 into main Mar 27, 2024
10 checks passed
@jonasteuwen jonasteuwen deleted the feature/3d-transforms branch March 27, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants