Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestions #113

Merged
merged 12 commits into from
Oct 9, 2020
Merged

Suggestions #113

merged 12 commits into from
Oct 9, 2020

Conversation

sverhoeven
Copy link
Member

@sverhoeven sverhoeven commented Oct 7, 2020 •
edited
Loading

Merges

Fixes

Before PR is merged for each post on medium

  • webassembly
    • update gists
    • update blogs images and text
    • add jan and daan to proof readers
  • web-worker
    • update gists
    • update blogs images and text
    • add carlos to proof readers
  • react
    • update gists
    • update blogs images and text
    • add daan to proof readers
  • vega
    • update gists
    • update blogs images and text
  • kitchen-sink
    • update gists
    • update blogs images and text

@sverhoeven sverhoeven mentioned this pull request Oct 7, 2020
Closed
@sverhoeven sverhoeven mentioned this pull request Oct 7, 2020
Closed
@sverhoeven sverhoeven marked this pull request as ready for review October 7, 2020 12:38
This was referenced Oct 7, 2020
Closed
Closed
fdiblen
fdiblen reviewed Oct 8, 2020
View reviewed changes
webassembly/README.md
```

This will generate a WebAssembly module ``newtonraphson.wasm``, along with a JavaScript file ``newtonraphson.js``. Using
this JavaScript library, we can find the root of the mathematical function, and subsequently display its value with the
This will generate a WebAssembly module ``newtonraphson.wasm``, along with a JavaScript file ``newtonraphson.js``. We also export the `createModule` JavaScript function in the compile command so it can be used to load and initialize the WebAssembly module.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a comment about naming of createModule.

fdiblen
fdiblen approved these changes Oct 8, 2020
View reviewed changes
Copy link
Collaborator

@fdiblen fdiblen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@sverhoeven sverhoeven merged commit a957caa into master Oct 9, 2020
@sverhoeven sverhoeven deleted the suggestions branch October 9, 2020 06:09
@sverhoeven sverhoeven mentioned this pull request Oct 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdiblen fdiblen fdiblen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sverhoeven @fdiblen @c-martinez