fix index name recognition. bug #37

NLPchina · Feb 28, 2015 · 48db9ff · 48db9ff
1 parent a584ca9
commit 48db9ff
Show file tree

Hide file tree

Showing 4 changed files with 60 additions and 17 deletions.
diff --git a/src/main/java/org/durid/sql/ast/statement/SQLExprTableSource.java b/src/main/java/org/durid/sql/ast/statement/SQLExprTableSource.java
@@ -34,6 +34,10 @@ public SQLExprTableSource(SQLExpr expr){
 		this.tablename = expr.toString().replace(" ", "");
     }
 
+	public SQLExprTableSource(String tablename){
+		this.tablename = tablename;
+	}
+
     public SQLExpr getExpr() {
         return this.expr;
     }

diff --git a/src/main/java/org/durid/sql/parser/Lexer.java b/src/main/java/org/durid/sql/parser/Lexer.java
@@ -67,10 +67,26 @@ public class Lexer {
 
     private int           varIndex     = -1;
 
+
     public Lexer(String input){
         this(input, true);
     }
 
+
+	public Lexer(String input, boolean skipComment){
+		this.skipComment = skipComment;
+
+		this.text = input;
+		this.pos = -1;
+
+		scanChar();
+	}
+
+
+	public Lexer(char[] input, int inputLength, boolean skipComment){
+		this(new String(input, 0, inputLength), skipComment);
+	}
+
     public final char charAt(int index) {
         if (index >= text.length()) {
             return EOI;
@@ -145,19 +161,6 @@ public void reset() {
         this.token = savePoint.token;
     }
 
-    public Lexer(String input, boolean skipComment){
-        this.skipComment = skipComment;
-
-        this.text = input;
-        this.pos = -1;
-
-        scanChar();
-    }
-
-    public Lexer(char[] input, int inputLength, boolean skipComment){
-        this(new String(input, 0, inputLength), skipComment);
-    }
-
     protected final void scanChar() {
         ch = charAt(++pos);
     }
@@ -375,6 +378,42 @@ public final void nextToken() {
 
     }
 
+
+	/**
+	 * Scan all values until first whitespace, spaces near ',' are ignored,
+	 * so values like 'hello , world' will capture as one token.
+	 * @return all names as string.
+	 */
+	public String scanNames() {
+		String restOfText = text.substring(pos);
+		String[] splittedText = restOfText.split(",");
+
+		StringBuilder names = new StringBuilder();
+		for (String textPart : splittedText) {
+			String trimmedTextPart = textPart.trim();
+
+			// is last part?
+			if(trimmedTextPart.contains(" ")) {
+				int whitespaceIndex = trimmedTextPart.indexOf(" ");
+				if(whitespaceIndex != -1) {
+					trimmedTextPart = trimmedTextPart.substring(0, whitespaceIndex);
+				}
+				names.append(trimmedTextPart);
+				while(isWhitespace(charAt(pos))) {
+					scanChar();
+				}
+				pos += whitespaceIndex + 1;
+				break;
+			}
+
+			names.append(trimmedTextPart + ",");
+			pos += textPart.length() + 1;
+		}
+
+		ch = charAt(pos);
+		return names.toString();
+	}
+
     private final void scanOperator() {
         switch (ch) {
             case '+':

diff --git a/src/main/java/org/durid/sql/parser/SQLSelectParser.java b/src/main/java/org/durid/sql/parser/SQLSelectParser.java
@@ -212,9 +212,9 @@ public void parseFrom(SQLSelectQueryBlock queryBlock) {
             return;
         }
 
-        lexer.nextToken();
-
-        queryBlock.setFrom(parseTableSource());
+		SQLTableSource source = new SQLExprTableSource(lexer.scanNames());
+        queryBlock.setFrom(source);
+		lexer.nextToken();
     }
 
     public SQLTableSource parseTableSource() {

diff --git a/src/test/java/org/nlpcn/es4sql/QueryTest.java b/src/test/java/org/nlpcn/es4sql/QueryTest.java
@@ -73,7 +73,7 @@ public void selectAliases() throws IOException, SqlParseException, SQLFeatureNot
 
 	@Test
 	public void equallityTest() throws SqlParseException, SQLFeatureNotSupportedException {
-		SearchHits response = query(String.format("select * from %s/phrase where city = 'Nogal' LIMIT 1000", TEST_INDEX));
+		SearchHits response = query(String.format("select * from %s/account where city = 'Nogal' LIMIT 1000", TEST_INDEX));
 		SearchHit[] hits = response.getHits();
 
 		// assert the results is correct according to accounts.json data.