Update tsne function due to dependency change in nlp.py #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent update to a dependency removed the need for the 'square_distance' argument in the tsne function, which is used within the calculate_embedding function in the nlp module. This commit updates the tsne function to no longer require the 'square_distance' argument. Fixes scikit-learn#12401
|
Looks good to me! Thanks for your contribution and thanks for looking into this! The CI failed due to the linter, but that is not the fault of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent update to a dependency removed the need for the 'square_distance' argument in the tsne function, which is used within the calculate_embedding function in the nlp module. This commit updates the tsne function to no longer require the 'square_distance' argument.
Fixes #54