Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pypi workflow? #196

Closed
jspaaks opened this issue Apr 20, 2021 · 3 comments · Fixed by #254
Closed

remove pypi workflow? #196

jspaaks opened this issue Apr 20, 2021 · 3 comments · Fixed by #254
Assignees
@sverhoeven
Labels
generated-package Related to the generated package, i.e. after running cookiecutter needs discussion question
Milestone
0.4.0

Comments

@jspaaks
Copy link

jspaaks commented Apr 20, 2021

We currently have a workflow that can be used to publish the generated package to pypi.

I prefer to not do this automatically but instead document how to do this as per https://github.com/NLeSC/python-template/blob/3ad0d5337226c31c2f236359bb4025bc5c192908/%7B%7Bcookiecutter.project_name%7D%7D/README.dev.rst
@jspaaks jspaaks added generated-package Related to the generated package, i.e. after running cookiecutter question standup labels Apr 20, 2021
@sverhoeven
Copy link
Member

I think we should treat pypi release as cattle not as a pet. So I prefer it to be automated.

We could add a publish to test pypi to the workflow, like how it is done in https://github.com/eWaterCycle/era5cli/blob/master/.github/workflows/publish-to-pypi.yml .

@fdiblen fdiblen added this to the 0.4.0 milestone Apr 28, 2021
@sverhoeven
Copy link
Member

sverhoeven commented Apr 28, 2021 •
edited
Loading

We decided to remove the workflow and remove chapter in project_setup.md

@sverhoeven sverhoeven self-assigned this Apr 29, 2021
sverhoeven added a commit that referenced this issue Apr 29, 2021
@sverhoeven
Removed publish workflow and its docs
011c28d 
Refs  #196
@sverhoeven sverhoeven mentioned this issue Apr 29, 2021
Merged
@bouweandela
Copy link
Member

Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sverhoeven sverhoeven

Labels
generated-package Related to the generated package, i.e. after running cookiecutter needs discussion question
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

Removed publish workflow and its docs NLeSC/python-template
4 participants
@fdiblen @sverhoeven @jspaaks @bouweandela