New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 370 (and 423) #426
Merged
Merged
Issue 370 (and 423) #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing (make it testable)
ximon18
reviewed
Feb 24, 2021
ximon18
reviewed
Feb 24, 2021
ximon18
reviewed
Feb 24, 2021
ximon18
reviewed
Feb 24, 2021
ximon18
reviewed
Feb 24, 2021
ximon18
reviewed
Feb 24, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
reviewed
Mar 16, 2021
ximon18
approved these changes
Mar 16, 2021
ximon18
approved these changes
Mar 17, 2021
ximon18
approved these changes
Mar 17, 2021
ximon18
approved these changes
Mar 17, 2021
ximon18
approved these changes
Mar 17, 2021
ximon18
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not finished.. making draft PR so reviewing can start.
I still want to add the work for #423 - because it's very related to all these changes.
There may still be things broken in the UI as well.
No rush.. I need to focus on some other things right now, but I propose that I get back to this with a better description of how this BIG change is implemented and what it's trying to achieve. But, feel free to look around!