Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldns-dane fails with assertion error in 1.8.2 #183

Closed
anandb-ripencc opened this issue Aug 14, 2022 · 6 comments
Closed

ldns-dane fails with assertion error in 1.8.2 #183

anandb-ripencc opened this issue Aug 14, 2022 · 6 comments

Comments

@anandb-ripencc
Copy link

With version 1.8.1 of ldns, the ldns-dane utility worked properly. However, after the upgrade to 1.8.2, it fails thus:

% ldns-dane create th-cho-as137566.anchors.atlas.ripe.net 443
Assertion failed: (rd != NULL), function ldns_rdf_size, file rdata.c, line 26.
[1]    51743 abort      ldns-dane create th-cho-as137566.anchors.atlas.ripe.net 443

This is on macOS 12.5, on a fully up to date system. I installed ldns from Homebrew, and earlier today, it got upgraded to 1.8.2 when I upgraded packages.

@leahneukirchen
Copy link

This also happens for drill -D and ssh with VerifyHostKeyDNS yes, see void-linux/void-packages#38669.

leahneukirchen added a commit to void-linux/void-packages that referenced this issue Aug 14, 2022
Avoid upstream issue NLnetLabs/ldns#183

Fixes #38669.
@Jakker
Copy link

Jakker commented Aug 14, 2022

A similar problem has reported for FreeBSD, see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=265814

wtoorop added a commit that referenced this issue Aug 14, 2022
@wtoorop
Copy link
Member

wtoorop commented Aug 14, 2022

Thanks! This was unfortunately (and surprisingly) not covered in one of the unit tests.
I have a fix committed (and attached in this comment as patch). I will make a quickfix 1.8.3 release with this fix shortly.

0001-Issue-183-EDNS-OPT-can-have-no-rdata.patch.gz

@wtoorop
Copy link
Member

wtoorop commented Aug 15, 2022

ldns-1.8.3 has been released with a quickfix for this.
Thank you @anandb-ripencc @leahneukirchen @Jakker for reporting this so promptly

@wtoorop wtoorop closed this as completed Aug 15, 2022
yuriy-chumak pushed a commit to otus-lisp/void-packages that referenced this issue Aug 15, 2022
@anandb-ripencc
Copy link
Author

Could you please tag 1.8.3 in GitHub too? Some projects, like Homebrew, look at the GitHub tags to determine whether a newer version is available or not, and without the tag, I can't update the Homebrew formula.

@wtoorop
Copy link
Member

wtoorop commented Aug 15, 2022

Could you please tag 1.8.3 in GitHub too? Some projects, like Homebrew, look at the GitHub tags to determine whether a newer version is available or not, and without the tag, I can't update the Homebrew formula.

Ack! I made it, but forgot to push. Now pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants