Fix strlcpy() usage. #115
Merged
Fix strlcpy() usage. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size argument should be the full size of the buffer, not the number of bytes to copy. The strlcpy() return value should be checked to verify that truncation did not occur.
wcawijngaards
approved these changes
Jul 23, 2020
wcawijngaards
added a commit
that referenced
this pull request
Jul 23, 2020
- Merge #115 from millert: Fix strlcpy() usage. From OpenBSD.
fanf2
pushed a commit
to fanf2/nsd
that referenced
this pull request
Aug 4, 2020
- Merge NLnetLabs#115 from millert: Fix strlcpy() usage. From OpenBSD.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The size argument should be the full size of the buffer, not the number of bytes to copy. The strlcpy() return value should be checked to verify that truncation did not occur. From OpenBSD.