-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build with --without-ssl #266
Conversation
It appears this breaks the FreeBSD build. Does it not set |
I finally got it. FreeBSD is using BSD make, not GNU make. I push a commit making |
Don't include COMMON_OBJ when compiling nsd-control without SSL. Without SSL, nsd-control's only purpose is to print out an error message. There's no need to include any other object files then. Signed-off-by: Eneas U de Queiroz <cotequeiroz@gmail.com>
Hi @cotequeiroz! Thanks for giving this a try! Also, sorry for the overdue reply... If my assumptions are correct: compiling without We definitely have to look into building without SSL because there's some oddities. I'll have a good look and see if I can do a non-ssl build and go from there. |
Hi @cotequeiroz, @wcawijngaards fixed the build issue in the commit referenced above. That should help you along. Not as nice as allowing local operation without SSL yet, but we can tackle that at a later stage. Thanks for taking the time for reporting and trying to come up with a fix. Much appreciated! |
Thanks. I suggest you add a CI build without ssl. |
All that was left outside of the Lines 607 to 613 in 64595da
|
Don't include COMMON_OBJ when compiling nsd-control without SSL.
Without SSL, nsd-control's only purpose is to print out an error message. There's no need to include any other object files then.
Signed-off-by: Eneas U de Queiroz cotequeiroz@gmail.com
Here's how the build fails with OpenWrt:
This was compile-tested with OpenWrt both without SSL and with OpenSSL 3.0.