Catalog zones #304
Merged
Catalog zones #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also change ident to "load" when reloading and the backup main process to "old-main". When reload succeeds, "load" will become "main" and "old-main" will quit. Otherwise "load" will be exited (because of failure) and "old_main" will continue as "main".
A version of dname_to_string() that writes to a buffer instead of returning a static buffer. This is useful when you need to print two dnames in a log message.
TODO: Group property
+ marshalling of the catalog zone pattern options
k0ekk0ek
reviewed
Nov 27, 2023
wtoorop
commented
Nov 27, 2023
|
Current version works fine for us 👍 (just replaced one of our test-installations of a previous catz-branch build) |
|
First issue encountered: A manual |
|
Next issue I see then I restart |
This seems to be related to configuration processing (like the previous catz work) |
instead of struct domain
TODO: - Check all cases where zones are added, deleted or changed for status change of: producer zones and producer member zones. - A zone could be a consumer member zone, *and* a producer zone or a producer member.
and process more than one transfer file. TODO change processing after successful SOAINFO ... before xfrd_unlink_xfrfile().
... check zonefile when asked to check.
The function can still exit via apply_ixfr() -> addRR() or deleteRR() when out of memory, but in that case all bets are off anyway, right?
wcawijngaards
approved these changes
Jan 26, 2024
wtoorop
commented
Jan 29, 2024
Thanks Wouter! I'll resolve the remaining reduce/reduce conflicts from command line. Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
Closed
k0ekk0ek
requested changes
Jan 29, 2024
k0ekk0ek
reviewed
Jan 29, 2024
k0ekk0ek
reviewed
Jan 29, 2024
k0ekk0ek
reviewed
Jan 29, 2024
Comment on lines
+315
to
+318
| uint8_t catalog_role; | ||
| uint8_t catalog_role_is_default; | ||
| const char* catalog_member_pattern; | ||
| const char* catalog_producer_zone; |
There was a problem hiding this comment.
Back when the first PR got made, we kind-of decided catalog properties must be set on a zone. A reason for that being so that you cannot all of a sudden break things simply by re-applying patterns. Why should this be part of a pattern?
There was a problem hiding this comment.
I evaluated this extensively. Have a look at the catzones.tdir and the text in the man page to see how this all works. The re-applying patterns issues are also covered in catzones.tdir.
Short summary: A catalog producer (catalog_role == CATALOG_ROLE_PRODUCER) is only functional when in a zone clause which is checked by evaluating the value for "catalog_producer_zone" (which only makes sense in a pattern and not in a zone; i.e. catalog member zones are always instantiated through patterns).
Currently only a single catalog consumer is allowed, but this may change in the future. In that future extension there is no reason why you would not have a catalog member zone which is a catalog consumer itself. But that's the future; we do it step by step. Currently it at least allows the user to configure a consumer zone in all the for nsd conventional manner.
k0ekk0ek
reviewed
Jan 29, 2024
k0ekk0ek
reviewed
Jan 29, 2024
wtoorop
commented
Jan 30, 2024
wtoorop
commented
Jan 30, 2024
wtoorop
commented
Jan 30, 2024
wtoorop
commented
Jan 30, 2024
wtoorop
commented
Jan 30, 2024
Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
Recover line to report an error Co-authored-by: Wouter Wijngaards <wcawijngaards@users.noreply.github.com>
... now used in a function prototype in dname.h + Some clarifying comments in the label_plus_dname() function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version does the task from within the tranfer daemon (xfrd) which makes everything easier and more straight forward.