Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the router-list and config-graph Cargo features #50

Merged
merged 71 commits into from
Oct 30, 2023

Conversation

ximon18
Copy link
Member

@ximon18 ximon18 commented Oct 30, 2023

As they complicate the code too much and we haven't ever used them. We can revisit restricting our dependency tree and build times later if needed, and building with --no-default-features is currently broken anyway as there would need to be even more use of the feature guards in the code base to make it work.

Replaces accidentally closed PR #44.

ximon18 and others added 30 commits October 20, 2023 14:05
…nda pipeline, with capture demonstrated for BMP messages and filtering in the bmp-in and rib units and output at /status/graph/traces/N, and adds a new MVP command line argument --bmp-tracing-mode. Does NOT update tests so those are likely broken at the moment.
…te metrics over fast metrics until it is shown that the speed of the metrics is actually a problem that needs fixing.
…bedded config file) working as there's no (easy) way to tell Docker then to run rotonda without args ala how it works outside of Docker.
This reverts commit 40565c8.
…cate the code too much and we haven't ever used them. We can revisit restricting our dependency tree and build times later if needed.
…)`, and disallow ALL as a MsgRelation for new trace messages.
@ximon18 ximon18 merged commit 8d46350 into blocks-wip Oct 30, 2023
1 check passed
@ximon18 ximon18 deleted the remove-graph-and-html-cargo-features branch October 30, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants