Fix "unknown-objects" config file key name (typo) #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the mismatch and thank you for the PR! Since renaming configuration keys is a breaking change, I would like to allow both keys for now and remove the old one with 0.9. Do you mind if I make a new PR for that? Allowing both is a bit fiddly at that place. |
|
Sure, go ahead! |
|
The PR has been incorporated in #416. |
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Nov 20, 2020
Pkgsrc changes: * None other than version bump. Upstream changes: Released 2020-11-20. Bug Fixes * VRPs filtered via local exceptions are dropped again. In 0.8.0, they were only added to the metrics but not actually dropped. ([#424], discovered by [@cwiech]) * The prefix validation option incorrectly matched VRPs for host prefixes to prefixes with an identical bit pattern of any length. (Found by [@vamseedhar-reddyvari] and fixed in [#415] by [@morrowc] and [@aaronw112358]) * The config file option for the policy on dealing with objects on unknown types is now correctly spelled `unknown-objects` (with a dash rather than an underscore). The old spelling will be also be accepted in 0.8 releases. (Found and fixed by [@johannesmoos], [#413], [#416].) * The config file option `rtr-tcp-keepalive` now accepts an integer value as it should have from the beginning (and the `config` command even created). For the time being, both integers and strings will be accepted. String values will be rejected starting with 0.9.0. ([#427], discovered by [@johannesmoos]) New * The log output of the HTTP `/log` endpoint now states the start date of the validation run it represents. ([#426]) Other Changes [#413]: NLnetLabs/routinator#413 [#415]: NLnetLabs/routinator#415 [#416]: NLnetLabs/routinator#416 [#424]: NLnetLabs/routinator#424 [#426]: NLnetLabs/routinator#426 [@johannesmoos]: https://github.com/johannesmoos [@morrowc]: https://github.com/morrowc [@aaronw112358]: https://github.com/aaronw112358 [@cwiech]: https://github.com/cwiech
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Nov 30, 2020
Pkgsrc changes: * Re-compute cargo dependencies * Farm out the cargo dependencies to its own file Upstream changes: Released 2020-11-30. There have been no changes since 0.8.1-rc1. Released 2020-11-20. Bug Fixes * VRPs filtered via local exceptions are dropped again. In 0.8.0, they were only added to the metrics but not actually dropped. ([#424], discovered by [@cwiech]) * The prefix validation option incorrectly matched VRPs for host prefixes to prefixes with an identical bit pattern of any length. (Found by [@vamseedhar-reddyvari] and fixed in [#415] by [@morrowc] and [@aaronw112358]) * The config file option for the policy on dealing with objects on unknown types is now correctly spelled `unknown-objects` (with a dash rather than an underscore). The old spelling will be also be accepted in 0.8 releases. (Found and fixed by [@johannesmoos], [#413], [#416].) * The config file option `rtr-tcp-keepalive` now accepts an integer value as it should have from the beginning (and the `config` command even created). For the time being, both integers and strings will be accepted. String values will be rejected starting with 0.9.0. ([#427], discovered by [@johannesmoos]) New * The log output of the HTTP `/log` endpoint now states the start date of the validation run it represents. ([#426]) [#413]: NLnetLabs/routinator#413 [#415]: NLnetLabs/routinator#415 [#416]: NLnetLabs/routinator#416 [#424]: NLnetLabs/routinator#424 [#426]: NLnetLabs/routinator#426 [@johannesmoos]: https://github.com/johannesmoos [@morrowc]: https://github.com/morrowc [@aaronw112358]: https://github.com/aaronw112358 [@cwiech]: https://github.com/cwiech
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename config file key name
unknown_objectstounknown-objects(as documentation states)