Directly log rsync error output. #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ximon18
reviewed
Jan 15, 2024
ximon18
approved these changes
Jan 15, 2024
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 25, 2024
Pkgsrc changes: * Bump version & re-compute cargo-depends. Upstream changes: New * Added support for private keys marked as "EC PRIVATE KEY" in the PEM files for TLS server configuration. ([#921]) * The rsync collector now logs stderr output of the rsync command directly instead of collecting it and logging it in one go after the commend returned. ([#290]) Bug Fixes * The `dump` command will now succeed even if certain directories or files in the repository cache are missing. ([#916]) * A more meaningful message is now printed when decoding RPKI objects fails. It will still not give much detail but at least it isn't confusing any more. ([#917]) Other changes * Updated the `nlnetlabs-testbed` TAL to the current location and key. ([#922]) [#916]: NLnetLabs/routinator#916 [#917]: NLnetLabs/routinator#917 [#920]: NLnetLabs/routinator#920 [#921]: NLnetLabs/routinator#921 [#922]: NLnetLabs/routinator#922
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the rsync collector to directly log all stderr output from the rsync command rather than collecting it and then blasting it out all at once which can cause issues with the syslog daemon on some systems.