Don’t have the RTR listener fail if a socket fails after accept. #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DRiKE
approved these changes
Feb 26, 2024
partim
added a commit
that referenced
this pull request
Feb 26, 2024
Bug Fixes * Fix the RTR listener so that Routinator won’t exit if an incoming RTR connection is closed again too quickly. ([#937], reported by Yohei Nishimura, Atsushi Enomoto, Ruka Miyachi; Internet Multifeed Co., Japan. Assigned [CVE-2024-1622].)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the RTR listener to not fail the accept loop when setting up a stream after accepting it fails. Instead it will quietly drop the stream in this case and keep going.
As part of this, the PR also drops tokio-stream as a dependency and implements its own listener stream.
This PR fixes CVE-2024-1622 reported by Yohei Nishimura, Atsushi Enomoto, Ruka Miyachi; Internet Multifeed Co., Japan.